Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update deployment object when adapter changes are detected #540

Merged
merged 3 commits into from
Jul 30, 2024

Conversation

bangqipropel
Copy link
Collaborator

@bangqipropel bangqipropel commented Jul 26, 2024

Reason for Change:

  1. Update deployment object when adapter changes are detected
  2. Include logic for comparing adapters
  3. Add unit test for deployment update

Copy link

codecov bot commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 56.92308% with 28 lines in your changes missing coverage. Please review.

Project coverage is 59.44%. Comparing base (ed546f0) to head (30137d3).
Report is 20 commits behind head on main.

Files Patch % Lines
pkg/resources/manifests.go 0.00% 18 Missing ⚠️
pkg/controllers/workspace_controller.go 78.72% 6 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #540      +/-   ##
==========================================
- Coverage   61.10%   59.44%   -1.66%     
==========================================
  Files          29       30       +1     
  Lines        2602     2868     +266     
==========================================
+ Hits         1590     1705     +115     
- Misses        921     1063     +142     
- Partials       91      100       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Fei-Guo Fei-Guo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to consider how the workspace status may change when we allow to update the inference spec. This can be done in next change.

Bangqi Zhu added 2 commits July 30, 2024 03:42
Signed-off-by: Bangqi Zhu <bangqizhu@microsoft.com>
Signed-off-by: Bangqi Zhu <bangqizhu@microsoft.com>
Signed-off-by: Bangqi Zhu <bangqizhu@microsoft.com>
@bangqipropel bangqipropel merged commit c54af47 into main Jul 30, 2024
6 of 8 checks passed
@bangqipropel bangqipropel deleted the bangqipropel/UpdateDeployment branch July 30, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants