Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add workspace status to present the tuning job status #529

Merged
merged 3 commits into from
Jul 21, 2024
Merged

Conversation

Fei-Guo
Copy link
Collaborator

@Fei-Guo Fei-Guo commented Jul 19, 2024

This PR made a few changes in terms of the workspace status update.

  • Since workspace CRD now supports both inference and tuning, the WorkspaceConditionTypeReady status is renamed to WorkspaceConditionTypeSucceeded, which can be used for both use cases to represent the overall status.
  • Add a WorkspaceConditionTypeTuningJobStatus to indicate that the job pod has started without error.
  • Since the controller has a watcher for the job, once job has changed its status to "succeeded", the reconciler will update the WorkspaceConditionTypeSucceeded status to true.
  • The CRD printed columns are also changed accordingly.

Copy link

codecov bot commented Jul 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 35 lines in your changes missing coverage. Please review.

Project coverage is 60.00%. Comparing base (ed546f0) to head (cb7eaa2).
Report is 12 commits behind head on main.

Files Patch % Lines
pkg/controllers/workspace_controller.go 0.00% 33 Missing ⚠️
pkg/resources/resources.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #529      +/-   ##
==========================================
- Coverage   61.10%   60.00%   -1.11%     
==========================================
  Files          29       30       +1     
  Lines        2602     2650      +48     
==========================================
  Hits         1590     1590              
- Misses        921      969      +48     
  Partials       91       91              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-authored-by: Ishaan Sehgal <ishaanforthewin@gmail.com>
Signed-off-by: Fei Guo <vrgf2003@gmail.com>
@Fei-Guo Fei-Guo merged commit 4d5cd2d into main Jul 21, 2024
4 of 6 checks passed
@Fei-Guo Fei-Guo deleted the fguo-dev1 branch July 21, 2024 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants