Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Tuning Resource Validation Check #484

Merged
merged 7 commits into from
Jun 27, 2024
Merged

feat: Tuning Resource Validation Check #484

merged 7 commits into from
Jun 27, 2024
+91 −38

Conversation

ishaansehgal99
Copy link
Collaborator

Reason for Change:
Tuning Resource Validation Check

@ishaansehgal99
Update Makefile
a80bec5 
Signed-off-by: Ishaan Sehgal <ishaanforthewin@gmail.com>
@codecov Codecov
Copy link

codecov bot commented Jun 27, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 60.95%. Comparing base (45e75aa) to head (a80bec5).
Report is 2 commits behind head on main.

❗ Current head a80bec5 differs from pull request most recent head 6cefe8c

Please upload reports for the commit 6cefe8c to get more accurate results.

Files Patch % Lines
api/v1alpha1/workspace_validation.go 70.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #484      +/-   ##
==========================================
+ Coverage   60.92%   60.95%   +0.03%     
==========================================
  Files          29       29              
  Lines        2559     2564       +5     
==========================================
+ Hits         1559     1563       +4     
- Misses        909      910       +1     
  Partials       91       91

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Fei-Guo
Fei-Guo reviewed Jun 27, 2024
View reviewed changes
@ishaansehgal99 ishaansehgal99 merged commit f70dcc5 into main Jun 27, 2024
6 checks passed
@ishaansehgal99 ishaansehgal99 deleted the Ishaan/validation-check branch June 27, 2024 03:37
smritidahal653 pushed a commit to smritidahal653/kaito that referenced this pull request Jul 12, 2024
@ishaansehgal99 @smritidahal653
feat: Tuning Resource Validation Check (kaito-project#484)
3396918 
**Reason for Change**:
Tuning Resource Validation Check

---------

Signed-off-by: Ishaan Sehgal <ishaanforthewin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fei-Guo Fei-Guo Fei-Guo approved these changes

@helayoty helayoty Awaiting requested review from helayoty helayoty is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ishaansehgal99 @Fei-Guo