Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: increase adapter test coverage #477

Merged
merged 3 commits into from
Jun 20, 2024

Conversation

bangqipropel
Copy link
Collaborator

Reason for Change:

Requirements

  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Notes for Reviewers:

Bangqi Zhu added 2 commits June 19, 2024 03:42
Signed-off-by: Bangqi Zhu <bangqizhu@microsoft.com>
Signed-off-by: Bangqi Zhu <bangqizhu@microsoft.com>
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.92%. Comparing base (b65dd2e) to head (d624c72).
Report is 34 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #477      +/-   ##
==========================================
- Coverage   61.09%   60.92%   -0.18%     
==========================================
  Files          29       29              
  Lines        2303     2559     +256     
==========================================
+ Hits         1407     1559     +152     
- Misses        828      909      +81     
- Partials       68       91      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bangqipropel bangqipropel enabled auto-merge (squash) June 19, 2024 17:58
Signed-off-by: Bangqi Zhu <bangqizhu@microsoft.com>
@bangqipropel bangqipropel disabled auto-merge June 19, 2024 21:39
@bangqipropel bangqipropel merged commit 7b874eb into main Jun 20, 2024
6 of 8 checks passed
@bangqipropel bangqipropel deleted the bangqipropel/adapter_unittests branch June 20, 2024 08:06
smritidahal653 pushed a commit to smritidahal653/kaito that referenced this pull request Jul 12, 2024
**Reason for Change**:
<!-- What does this PR improve or fix in Kaito? Why is it needed? -->

**Requirements**

- [ ] added unit tests and e2e tests (if applicable).

**Issue Fixed**:
<!-- If this PR fixes GitHub issue 4321, add "Fixes #4321" to the next
line. -->

**Notes for Reviewers**:

---------

Signed-off-by: Bangqi Zhu <bangqizhu@microsoft.com>
Co-authored-by: Bangqi Zhu <bangqizhu@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants