Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Phi3 Mini Requirements & Set Active Adapter #469

Merged
merged 10 commits into from
Jun 13, 2024
Merged

feat: Add Phi3 Mini Requirements & Set Active Adapter #469

merged 10 commits into from
Jun 13, 2024
+292 −48

Conversation

ishaansehgal99
Copy link
Collaborator

@ishaansehgal99 ishaansehgal99 commented Jun 13, 2024 •
edited
Loading

Reason for Change:
Add the requirements for Phi3 Mini Model
Add updated libraries needed for Phi3
Bug fix to set active adapter to weighted one in inference

@codecov Codecov
Copy link

codecov bot commented Jun 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.04%. Comparing base (b65dd2e) to head (aecb94f).
Report is 30 commits behind head on main.

❗ Current head aecb94f differs from pull request most recent head 8c43632

Please upload reports for the commit 8c43632 to get more accurate results.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #469      +/-   ##
==========================================
- Coverage   61.09%   60.04%   -1.05%     
==========================================
  Files          29       29              
  Lines        2303     2553     +250     
==========================================
+ Hits         1407     1533     +126     
- Misses        828      926      +98     
- Partials       68       94      +26

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ishaansehgal99 ishaansehgal99 changed the title feat: Add Phi3 Mini feat: Add Phi3 Mini Requirements and Minor Fix Ensuring Correct Active Adapter Jun 13, 2024
@ishaansehgal99 ishaansehgal99 changed the title feat: Add Phi3 Mini Requirements and Minor Fix Ensuring Correct Active Adapter feat: Add Phi3 Mini Requirements & Fix Active Adapter Issue Jun 13, 2024
@ishaansehgal99 ishaansehgal99 changed the title feat: Add Phi3 Mini Requirements & Fix Active Adapter Issue feat: Add Phi3 Mini Requirements & Set Active Adapter Jun 13, 2024
@ishaansehgal99 ishaansehgal99 merged commit 3ef8e66 into main Jun 13, 2024
5 of 9 checks passed
@ishaansehgal99 ishaansehgal99 deleted the Ishaan/add-phi-3-mini branch June 13, 2024 17:51
smritidahal653 pushed a commit to smritidahal653/kaito that referenced this pull request Jul 12, 2024
@ishaansehgal99 @smritidahal653
feat: Add Phi3 Mini Requirements & Set Active Adapter (kaito-project#469
a3b56da 
)

**Reason for Change**:
Add the requirements for Phi3 Mini Model
Add updated libraries needed for Phi3
Bug fix to set active adapter to weighted one in inference
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fei-Guo Fei-Guo Awaiting requested review from Fei-Guo Fei-Guo is a code owner

@helayoty helayoty Awaiting requested review from helayoty helayoty is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ishaansehgal99