feat: Automate the adapters manifests #463
Merged
+385
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
June 6, 2024 22:28
**Reason for Change**: Add adapters to inference API and update the required package **Requirements** - [ ] added unit tests and e2e tests (if applicable). **Issue Fixed**: <!-- If this PR fixes GitHub issue 4321, add "Fixes #4321" to the next line. --> **Notes for Reviewers**: Signed-off-by: Bangqi Zhu <bangqizhu@microsoft.com>
Signed-off-by: Bangqi Zhu <bangqizhu@microsoft.com>
Signed-off-by: Bangqi Zhu <bangqizhu@microsoft.com>
Signed-off-by: Bangqi Zhu <bangqizhu@microsoft.com>
Signed-off-by: Bangqi Zhu <bangqizhu@microsoft.com>
Signed-off-by: Bangqi Zhu <bangqizhu@microsoft.com>
Signed-off-by: Bangqi Zhu <bangqizhu@microsoft.com>
Signed-off-by: Bangqi Zhu <bangqizhu@microsoft.com>
Signed-off-by: Bangqi Zhu <bangqizhu@microsoft.com>
Signed-off-by: Bangqi Zhu <bangqizhu@microsoft.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #463 +/- ##
==========================================
- Coverage 61.09% 60.04% -1.05%
==========================================
Files 29 29
Lines 2303 2553 +250
==========================================
+ Hits 1407 1533 +126
- Misses 828 926 +98
- Partials 68 94 +26 ☔ View full report in Codecov by Sentry. |
Fei-Guo
reviewed
Jun 7, 2024
Signed-off-by: Bangqi Zhu <bangqizhu@microsoft.com>
Fei-Guo
reviewed
Jun 8, 2024
Signed-off-by: Bangqi Zhu <bangqizhu@microsoft.com>
Signed-off-by: Bangqi Zhu <bangqizhu@microsoft.com>
examples/inference/kaito_workspace_falcon_7b_with_adapters.yaml
Outdated
Show resolved
Hide resolved
| @@ -56,13 +57,14 @@ var ( | |||
| tolerations = []corev1.Toleration{ | |||
| { | |||
| Effect: corev1.TaintEffectNoSchedule, | |||
| Operator: corev1.TolerationOpEqual, | |||
| Key: resources.GPUString, | |||
| Operator: corev1.TolerationOpExists, | |||
There was a problem hiding this comment.
Why change from corev1.TolerationOpEqual to corev1.TolerationOpExists
There was a problem hiding this comment.
The origin one was different from the yaml file, and it will make the adapter cannot find the node
| Operator: corev1.TolerationOpEqual, | ||
| Key: resources.GPUString, | ||
| Operator: corev1.TolerationOpExists, | ||
| Key: resources.CapacityNvidiaGPU, |
There was a problem hiding this comment.
Similiar question on why change to resources.CapacityNvidiaGPU here. these tolerations should ideally not need to be changed...
Signed-off-by: Bangqi Zhu <bangqizhu@microsoft.com>
ishaansehgal99
approved these changes
Jun 12, 2024
smritidahal653
pushed a commit
to smritidahal653/kaito
that referenced
this pull request
Jul 12, 2024
**Reason for Change**: <!-- What does this PR improve or fix in Kaito? Why is it needed? --> **Requirements** - [ ] added unit tests and e2e tests (if applicable). **Issue Fixed**: <!-- If this PR fixes GitHub issue 4321, add "Fixes #4321" to the next line. --> **Notes for Reviewers**: --------- Signed-off-by: Bangqi Zhu <bangqizhu@microsoft.com> Co-authored-by: Bangqi Zhu <bangqizhu@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Requirements
Issue Fixed:
Notes for Reviewers: