fix: Update controller-gen version #429
Merged
+256
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #429 +/- ##
==========================================
- Coverage 61.09% 60.00% -1.09%
==========================================
Files 29 29
Lines 2303 2403 +100
==========================================
+ Hits 1407 1442 +35
- Misses 828 887 +59
- Partials 68 74 +6 ☔ View full report in Codecov by Sentry. |
Fei-Guo
approved these changes
May 21, 2024
smritidahal653
pushed a commit
to smritidahal653/kaito
that referenced
this pull request
Jun 7, 2024
**Reason for Change**: - Bumb controller-gen version to 0.15.0 - Add make generate step in both unit tests and e2e tests pipelines. **Requirements** - [ ] added unit tests and e2e tests (if applicable). **Issue Fixed**: <!-- If this PR fixes GitHub issue 4321, add "Fixes #4321" to the next line. --> **Notes for Reviewers**: --------- Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com> Co-authored-by: ishaansehgal99 <ishaanforthewin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Requirements
Issue Fixed:
Notes for Reviewers: