feat: Add feature gates flag #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
57497fd to
afe588d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #368 +/- ##
==========================================
+ Coverage 62.89% 64.64% +1.75%
==========================================
Files 14 29 +15
Lines 1307 2130 +823
==========================================
+ Hits 822 1377 +555
- Misses 447 686 +239
- Partials 38 67 +29 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>
afe588d to
8de55ba
Compare
Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>
d1723e1 to
c2ba309
Compare
Fei-Guo
reviewed
May 1, 2024
Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>
Fei-Guo
approved these changes
May 1, 2024
smritidahal653
pushed a commit
to smritidahal653/kaito
that referenced
this pull request
Jun 7, 2024
**Reason for Change**: - Add `feature-gates` flag to the Kaito controller. - Support the `karpenter` feature gate with default value, `false`. - Enable setting the feature gate flag via helm chart. In addition to some chores: - Exclude the auto generated and mock files from unit test coverage. - Upgrade k8s version using in the tests to the current supported version. **Requirements** - [x] added unit tests and e2e tests (if applicable). **Issue Fixed**: <!-- If this PR fixes GitHub issue 4321, add "Fixes #4321" to the next line. --> **Notes for Reviewers**: --------- Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
feature-gatesflag to the Kaito controller.karpenterfeature gate with default value,false.In addition to some chores:
Requirements
Issue Fixed:
Notes for Reviewers: