Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add URL as data source #365

Merged
merged 2 commits into from
Apr 30, 2024
Merged

feat: Add URL as data source #365

merged 2 commits into from
Apr 30, 2024

Conversation

ishaansehgal99
Copy link
Collaborator

Reason for Change:
Add URL as a data source
Requirements

  • added unit tests and e2e tests (if applicable).

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 93.10345% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 64.39%. Comparing base (fde6369) to head (a4444aa).
Report is 16 commits behind head on main.

Files Patch % Lines
pkg/tuning/preset-tuning.go 93.10% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #365      +/-   ##
==========================================
+ Coverage   62.89%   64.39%   +1.50%     
==========================================
  Files          14       28      +14     
  Lines        1307     2115     +808     
==========================================
+ Hits          822     1362     +540     
- Misses        447      686     +239     
- Partials       38       67      +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Fei-Guo Fei-Guo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not in this change, but can you refactor the ConfigDataVolume method? "" input is hard to understand. Maybe changing the input hostpath to *string type and use nil if hostpath is not configured.

@ishaansehgal99 ishaansehgal99 merged commit a9af171 into main Apr 30, 2024
5 checks passed
@ishaansehgal99 ishaansehgal99 deleted the Ishaan/URL branch April 30, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants