-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [SKU modularization] adding aws sku handler #364
Merged
Fei-Guo
merged 2 commits into
kaito-project:main
from
smritidahal653:sku_modularization
Apr 26, 2024
Merged
feat: [SKU modularization] adding aws sku handler #364
Fei-Guo
merged 2 commits into
kaito-project:main
from
smritidahal653:sku_modularization
Apr 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fei-Guo
approved these changes
Apr 26, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #364 +/- ##
==========================================
+ Coverage 62.89% 63.78% +0.89%
==========================================
Files 14 28 +14
Lines 1307 1966 +659
==========================================
+ Hits 822 1254 +432
- Misses 447 650 +203
- Partials 38 62 +24 ☔ View full report in Codecov by Sentry. |
ishaansehgal99
approved these changes
Apr 26, 2024
Fei-Guo
approved these changes
Apr 26, 2024
auto-merge was automatically disabled
April 26, 2024 20:59
Pull request was closed
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Adding implementation for AWS sku handler along with unit test
Requirements
Issue Fixed:
Notes for Reviewers: