Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add tuning job manifest, image source creation, parameter setup - Part 8 #363

Merged
merged 6 commits into from
Apr 28, 2024

Conversation

ishaansehgal99
Copy link
Collaborator

Reason for Change:
This PR includes the tuning job manifest, along with the init container for setting up the dataset, and the cmd line params needed.

@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 122 lines in your changes are missing coverage. Please review.

Project coverage is 60.11%. Comparing base (fde6369) to head (60e45b7).
Report is 15 commits behind head on main.

❗ Current head 60e45b7 differs from pull request most recent head 1449032. Consider uploading reports for the commit 1449032 to get more accurate results

Files Patch % Lines
pkg/tuning/preset-tuning.go 0.00% 68 Missing ⚠️
pkg/resources/manifests.go 0.00% 54 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #363      +/-   ##
==========================================
- Coverage   62.89%   60.11%   -2.78%     
==========================================
  Files          14       28      +14     
  Lines        1307     2086     +779     
==========================================
+ Hits          822     1254     +432     
- Misses        447      770     +323     
- Partials       38       62      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ishaansehgal99 ishaansehgal99 merged commit 962e3d6 into main Apr 28, 2024
3 of 5 checks passed
@ishaansehgal99 ishaansehgal99 deleted the Ishaan/add-datasrc-img branch April 28, 2024 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants