feat: Update CRD to add Volume and ConfigTemplate #356
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
This change removes hostPath field in DataSource and DataDestination struct. Instead, a standard K8s VolumeSource API is used to specify the volumes used by the tuning Job. This will provide the highest flexibility for users to load/store the data. HostPath field is hard to use in practice.
This change also renames the Config to ConfigTemplate because the final configmap used by the tuning job will be generated by the controller based on the template. The new name is clearer.
Notes for Reviewers:
We will revisit how to do validation check for the Volume field because it is a fairly complicated API.