Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Simple Configmap Validation Checks - Part 6 #355

Merged
merged 19 commits into from
Apr 19, 2024

Conversation

ishaansehgal99
Copy link
Collaborator

Reason for Change:
This PR adds two simple checks to the tuning configmap - makes sure based on the method specified (LoRa or QLoRa) the correct params are included. Also checks to make sure all the sections specified in the configmap are recognized.

Copy link
Collaborator

@Fei-Guo Fei-Guo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you going to have two default templates: one for lora and one for qlora? In this pr, you need to upload the default template to the helm deployment.

@codecov-commenter
Copy link

codecov-commenter commented Apr 17, 2024

Codecov Report

Attention: Patch coverage is 54.28571% with 48 lines in your changes are missing coverage. Please review.

Project coverage is 61.94%. Comparing base (fde6369) to head (5984663).
Report is 7 commits behind head on main.

Files Patch % Lines
api/v1alpha1/params_validation.go 54.87% 22 Missing and 15 partials ⚠️
api/v1alpha1/workspace_validation.go 52.17% 9 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #355      +/-   ##
==========================================
- Coverage   62.89%   61.94%   -0.95%     
==========================================
  Files          14       15       +1     
  Lines        1307     1406      +99     
==========================================
+ Hits          822      871      +49     
- Misses        447      480      +33     
- Partials       38       55      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ishaansehgal99 ishaansehgal99 merged commit 6be8a0d into main Apr 19, 2024
5 checks passed
@ishaansehgal99 ishaansehgal99 deleted the Ishaan/add-cm-tests branch April 19, 2024 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants