-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Simple Configmap Validation Checks - Part 6 #355
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you going to have two default templates: one for lora and one for qlora? In this pr, you need to upload the default template to the helm deployment.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #355 +/- ##
==========================================
- Coverage 62.89% 61.94% -0.95%
==========================================
Files 14 15 +1
Lines 1307 1406 +99
==========================================
+ Hits 822 871 +49
- Misses 447 480 +33
- Partials 38 55 +17 ☔ View full report in Codecov by Sentry. |
Reason for Change:
This PR adds two simple checks to the tuning configmap - makes sure based on the method specified (LoRa or QLoRa) the correct params are included. Also checks to make sure all the sections specified in the configmap are recognized.