Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add registry as a pipeline job output #329

Merged
merged 2 commits into from
Apr 1, 2024
Merged

Conversation

helayoty
Copy link
Collaborator

@helayoty helayoty commented Mar 29, 2024

Reason for Change:

  • The job output for registry was missing.
  • calling the output should use the job name, not step one.

Requirements

  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Notes for Reviewers:

@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.87%. Comparing base (8d0976f) to head (a3040f9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #329   +/-   ##
=======================================
  Coverage   63.87%   63.87%           
=======================================
  Files          14       14           
  Lines        1301     1301           
=======================================
  Hits          831      831           
  Misses        432      432           
  Partials       38       38           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

helayoty added 2 commits April 1, 2024 09:30
Signed-off-by: Heba <31887807+helayoty@users.noreply.github.com>
Signed-off-by: Heba <31887807+helayoty@users.noreply.github.com>
@helayoty helayoty disabled auto-merge April 1, 2024 19:34
@helayoty helayoty merged commit ee9101a into main Apr 1, 2024
5 checks passed
@helayoty helayoty deleted the helayoty/add-output branch April 1, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants