Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

failed calling webhook when namespace is not kaito-workspace #336

Closed
philwelz opened this issue Apr 3, 2024 · 1 comment · Fixed by #337
Closed

failed calling webhook when namespace is not kaito-workspace #336

philwelz opened this issue Apr 3, 2024 · 1 comment · Fixed by #337
Labels
bug Something isn't working

Comments

@philwelz
Copy link

philwelz commented Apr 3, 2024

Describe the bug

If you follow the installation docs here and here it is stated to install the workspace controller to the namespace kaito-workspace. But when you do this, you get an validation error when adding any preset model.

Steps To Reproduce

helm repo add kaito https://azure.github.io/kaito/charts/kaito
helm repo update
helm install workspace kaito/workspace --namespace kaito-workspace --create-namespace
kubectl apply -f https://raw.githubusercontent.com/Azure/kaito/main/examples/inference/kaito_workspace_phi-2.yaml

Expected behavior

Installation in any namespace should be to final solution, but until that the docs should be adopted.

Logs

Error from server (InternalError): error when creating "https://raw.githubusercontent.com/Azure/kaito/main/examples/inference/kaito_workspace_phi-2.yaml": Internal error occurred: failed calling webhook "validation.workspace.kaito.sh": failed to call webhook: Post "https://workspace.workspace.svc:9443/?timeout=10s": service "workspace" not found

Environment

  • Kubernetes version (use kubectl version): v1.28.5

Additional context

PR for this is created here #334

@ishaansehgal99
Copy link
Collaborator

ishaansehgal99 commented Apr 3, 2024

Thanks for pointing out this issue with the namespace reference in our Helm chart. We've identified the problem and are addressing it in Pull Request #337, which will be included in our next release. Until then, please install the workspace controller using the workspace namespace as a temporary workaround. Apologies for the inconvenience and appreciate your patience.

helayoty added a commit that referenced this issue Apr 4, 2024
**Reason for Change**:
- Update the namespace to use the release namespace.

**Requirements**

- [ ] added unit tests and e2e tests (if applicable).

**Issue Fixed**:
Fixes #336 
**Notes for Reviewers**:

---------

Signed-off-by: Heba <31887807+helayoty@users.noreply.github.com>
Co-authored-by: ishaansehgal99 <ishaanforthewin@gmail.com>
helayoty added a commit that referenced this issue Apr 4, 2024
**Reason for Change**:
- Update the namespace to use the release namespace.

**Requirements**

- [ ] added unit tests and e2e tests (if applicable).

**Issue Fixed**:
Fixes #336 
**Notes for Reviewers**:

---------

Signed-off-by: Heba <31887807+helayoty@users.noreply.github.com>
Co-authored-by: ishaansehgal99 <ishaanforthewin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants