feat: Add global client, accessible via webhooks (#353)

**Reason for Change**:
Add global client, accessible via webhooks

In this PR I also
Separate setup and execution phase of webhook server, allows us to
handle setup errors and setup context before attempting to run the
webhook server

cmd/main.go

@@ -4,6 +4,7 @@ package main
 
 import (
 	"flag"
+	"github.com/azure/kaito/pkg/k8sclient"
 	"os"
 	"strconv"
 	"time"
@@ -98,8 +99,10 @@ func main() {
 		exitWithErrorFunc()
 	}
 
+	k8sclient.SetGlobalClient(mgr.GetClient())
+
 	if err = (&controllers.WorkspaceReconciler{
-		Client:   mgr.GetClient(),
+		Client:   k8sclient.GetGlobalClient(),
 		Log:      log.Log.WithName("controllers").WithName("Workspace"),
 		Scheme:   mgr.GetScheme(),
 		Recorder: mgr.GetEventRecorderFor("KAITO-Workspace-controller"),
@@ -120,21 +123,20 @@ func main() {
 
 	if enableWebhook {
 		klog.InfoS("starting webhook reconcilers")
-		go func() {
-			p, err := strconv.Atoi(os.Getenv(WebhookServicePort))
-			if err != nil {
-				klog.ErrorS(err, "unable to parse the webhook port number")
-				exitWithErrorFunc()
-			}
-			ctx := webhook.WithOptions(signals.NewContext(), webhook.Options{
-				ServiceName: os.Getenv(WebhookServiceName),
-				Port:        p,
-				SecretName:  "workspace-webhook-cert",
-			})
-			ctx = sharedmain.WithHealthProbesDisabled(ctx)
-			ctx = sharedmain.WithHADisabled(ctx)
-			sharedmain.MainWithConfig(ctx, "webhook", ctrl.GetConfigOrDie(), webhooks.NewWebhooks()...)
-		}()
+		p, err := strconv.Atoi(os.Getenv(WebhookServicePort))
+		if err != nil {
+			klog.ErrorS(err, "unable to parse the webhook port number")
+			exitWithErrorFunc()
+		}
+		ctx := webhook.WithOptions(signals.NewContext(), webhook.Options{
+			ServiceName: os.Getenv(WebhookServiceName),
+			Port:        p,
+			SecretName:  "workspace-webhook-cert",
+		})
+		ctx = sharedmain.WithHealthProbesDisabled(ctx)
+		ctx = sharedmain.WithHADisabled(ctx)
+		go sharedmain.MainWithConfig(ctx, "webhook", ctrl.GetConfigOrDie(), webhooks.NewWebhooks()...)
+
 		// wait 2 seconds to allow reconciling webhookconfiguration and service endpoint.
 		time.Sleep(2 * time.Second)
 	}

pkg/k8sclient/client.go

@@ -0,0 +1,17 @@
+// Copyright (c) Microsoft Corporation.
+// Licensed under the MIT license.
+package k8sclient
+
+import (
+	"sigs.k8s.io/controller-runtime/pkg/client"
+)
+
+var Client client.Client
+
+func SetGlobalClient(c client.Client) {
+	Client = c
+}
+
+func GetGlobalClient() client.Client {
+	return Client
+}