Skip to content

Commit

Permalink
feat: add Nodeclaim & Machine provision to RAG Engine controller (#622)
Browse files Browse the repository at this point in the history
**Reason for Change**:
add Nodeclaim and Machine provision to RAG Engine controller

**Requirements**

- [ ] added unit tests and e2e tests (if applicable).

**Issue Fixed**:
<!-- If this PR fixes GitHub issue 4321, add "Fixes #4321" to the next
line. -->

**Notes for Reviewers**:

---------

Signed-off-by: Bangqi Zhu <bangqizhu@microsoft.com>
Co-authored-by: Bangqi Zhu <bangqizhu@microsoft.com>
Co-authored-by: Fei Guo <guofei@microsoft.com>
  • Loading branch information
3 people authored Oct 22, 2024
1 parent 941170b commit 544df3f
Show file tree
Hide file tree
Showing 12 changed files with 802 additions and 35 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,14 @@ package v1alpha1
type ConditionType string

const (
// WorkspaceConditionTypeMachineStatus is the state when checking machine status.
WorkspaceConditionTypeMachineStatus = ConditionType("MachineReady")
// ConditionTypeMachineStatus is the state when checking machine status.
ConditionTypeMachineStatus = ConditionType("MachineReady")

// WorkspaceConditionTypeNodeClaimStatus is the state when checking nodeClaim status.
WorkspaceConditionTypeNodeClaimStatus = ConditionType("NodeClaimReady")
// ConditionTypeNodeClaimStatus is the state when checking nodeClaim status.
ConditionTypeNodeClaimStatus = ConditionType("NodeClaimReady")

// WorkspaceConditionTypeResourceStatus is the state when Resource has been created.
WorkspaceConditionTypeResourceStatus = ConditionType("ResourceReady")
// ConditionTypeResourceStatus is the state when Resource has been created.
ConditionTypeResourceStatus = ConditionType("ResourceReady")

// WorkspaceConditionTypeInferenceStatus is the state when Inference service has been ready.
WorkspaceConditionTypeInferenceStatus = ConditionType("InferenceReady")
Expand Down
5 changes: 5 additions & 0 deletions api/v1alpha1/zz_generated.deepcopy.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions charts/kaito/ragengine/crds/kaito.sh_ragengines.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,7 @@ spec:
preferredNodes:
description: |-
PreferredNodes is an optional node list specified by the user.
If a node in the list does not have the required labels or
the required instanceType, it will be ignored.
If a node in the list does not have the required labels, it will be ignored.
items:
type: string
type: array
Expand Down
3 changes: 1 addition & 2 deletions charts/kaito/workspace/crds/kaito.sh_workspaces.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -212,8 +212,7 @@ spec:
preferredNodes:
description: |-
PreferredNodes is an optional node list specified by the user.
If a node in the list does not have the required labels or
the required instanceType, it will be ignored.
If a node in the list does not have the required labels, it will be ignored.
items:
type: string
type: array
Expand Down
3 changes: 1 addition & 2 deletions config/crd/bases/kaito.sh_ragengines.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,7 @@ spec:
preferredNodes:
description: |-
PreferredNodes is an optional node list specified by the user.
If a node in the list does not have the required labels or
the required instanceType, it will be ignored.
If a node in the list does not have the required labels, it will be ignored.
items:
type: string
type: array
Expand Down
3 changes: 1 addition & 2 deletions config/crd/bases/kaito.sh_workspaces.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -212,8 +212,7 @@ spec:
preferredNodes:
description: |-
PreferredNodes is an optional node list specified by the user.
If a node in the list does not have the required labels or
the required instanceType, it will be ignored.
If a node in the list does not have the required labels, it will be ignored.
items:
type: string
type: array
Expand Down
Loading

0 comments on commit 544df3f

Please sign in to comment.