Skip to content

Commit

Permalink
ci: Add Env variable for supported models yaml (#376)
Browse files Browse the repository at this point in the history
**Reason for Change**:
Add Env variable for supported models yaml

---------

Signed-off-by: Ishaan Sehgal <ishaanforthewin@gmail.com>
  • Loading branch information
ishaansehgal99 authored May 9, 2024
1 parent cc8e02d commit 4bac047
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
2 changes: 2 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ GPU_PROVISIONER_MSI_NAME ?= gpuIdentity
RUN_LLAMA_13B ?= false
AI_MODELS_REGISTRY ?= modelregistry.azurecr.io
AI_MODELS_REGISTRY_SECRET ?= modelregistry
SUPPORTED_MODELS_YAML_PATH ?= /home/runner/work/kaito/kaito/presets/models/supported_models.yaml

# Scripts
GO_INSTALL := ./hack/go-install.sh
Expand Down Expand Up @@ -111,6 +112,7 @@ GINKGO_ARGS ?= -focus="$(GINKGO_FOCUS)" -skip="$(GINKGO_SKIP)" -nodes=$(GINKGO_N
kaito-workspace-e2e-test: $(E2E_TEST) $(GINKGO)
AI_MODELS_REGISTRY_SECRET=$(AI_MODELS_REGISTRY_SECRET) RUN_LLAMA_13B=$(RUN_LLAMA_13B) \
AI_MODELS_REGISTRY=$(AI_MODELS_REGISTRY) GPU_NAMESPACE=$(GPU_NAMESPACE) KAITO_NAMESPACE=$(KAITO_NAMESPACE) \
SUPPORTED_MODELS_YAML_PATH=$(SUPPORTED_MODELS_YAML_PATH) \
$(GINKGO) -v -trace $(GINKGO_ARGS) $(E2E_TEST)

.PHONY: create-rg
Expand Down
4 changes: 3 additions & 1 deletion test/e2e/preset_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -337,6 +337,7 @@ func deleteWorkspace(workspaceObj *kaitov1alpha1.Workspace) error {
var runLlama13B bool
var aiModelsRegistry string
var aiModelsRegistrySecret string
var supportedModelsYamlPath string
var modelInfo map[string]string

var _ = Describe("Workspace Preset", func() {
Expand All @@ -351,9 +352,10 @@ var _ = Describe("Workspace Preset", func() {

aiModelsRegistry = utils.GetEnv("AI_MODELS_REGISTRY")
aiModelsRegistrySecret = utils.GetEnv("AI_MODELS_REGISTRY_SECRET")
supportedModelsYamlPath = utils.GetEnv("SUPPORTED_MODELS_YAML_PATH")

// Load stable model versions
configs, err := utils.GetModelConfigInfo("/home/runner/work/kaito/kaito/presets/models/supported_models.yaml")
configs, err := utils.GetModelConfigInfo(supportedModelsYamlPath)
if err != nil {
fmt.Printf("Failed to load model configs: %v\n", err)
os.Exit(1)
Expand Down

0 comments on commit 4bac047

Please sign in to comment.