Fix setup.py to work with setuptools 41.4.0 and later #46
Conversation
Manually parsing setup.cfg and passing the parsed data into the setup function is not officially supported by setuptools (see pypa/setuptools#1869) and is also unnecessary, because the setup function will automatically read the relevant data from setup.cfg.
|
I can't check this myself currently — can someone else double-check what it is indeed the solution and we can proceed? |
|
@GreyCat @dgelessus I've created a simple repo ks-python-runtime-setuptools-test testing the setup.py against various versions of Python and setuptools, using the runtime libraries But there is some issue with installing the setuptools in some version combinations, could you please look at the GH Actions logs to explore it more, @dgelessus? I've invited you as a collaborator, you should see some invitation here. I have no idea what's wrong with that, I'm not familiar with the Python, |
|
@GreyCat It seems that this PR really solves the problem explained in #45, here's the evidence: https://github.com/generalmimon/ks-python-runtime-setuptools-test/actions/runs/92079674. I've finally managed to fix the build. The GH Actions are really handy 👍 |
|
@generalmimon, you sir just continue to amaze me — going forward with such large-scale testing and really proving what is what :) @dgelessus, thanks for contributing this fix! |
Fixes #43 and fixes #45 and fixes #47.
This change is effectively also included in #39, but there hasn't been any progress on that PR recently. The setuptools compatibility issue has been reported multiple times recently (which makes sense - the current code is incompatible with many recent setuptools versions), so I think it makes sense to apply this fix separately from the larger PR #39.