Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing dependencies and fix cases of imported components #2

Merged
merged 1 commit into from
Mar 31, 2016

Conversation

ryanswrt
Copy link

I wasn't able to run the demo due to package import errors - fixed them up, and now it works for me, would like to know if this is a valid fix or if I'm doing something else incorrectly.

@arunoda
Copy link
Contributor

arunoda commented Mar 31, 2016

Okay. Are you using npm@2 ?
Anyway. This is great.

@arunoda arunoda merged commit 0327248 into kadira-samples:master Mar 31, 2016
@ryanswrt
Copy link
Author

Yep, using npm 2.14

@ryanswrt
Copy link
Author

And thanks a lot btw, finally got coffeescript react components to hot reload using storybook, after working on it for 5 or so days using other packages; can finally write Jade like templates in React without relying on another loader.

@arunoda
Copy link
Contributor

arunoda commented Mar 31, 2016

Awesome. Glad you like it a lot :)
We used this with npm@3 and that's why we didn't face that issue.

We should do some testing with NPM@2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants