Fix replay BVF errors #2121
Merged
Fix replay BVF errors #2121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason, I reverted execReadOnlyReplay to stop using CheckablePayloadWithOutputs, which makes the errors very hard to use, because there's no "expected" output printed. Change-Id: Id00000002157778ccb796c0ebee738d431edc4b5
chessai
approved these changes
Jan 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, I reverted execReadOnlyReplay to stop using CheckablePayloadWithOutputs, which makes the errors very hard to use, because there's no "expected" output printed.
Change-Id: Id00000002157778ccb796c0ebee738d431edc4b5