Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pactjs-cli): fixed incorrect network by extracting data from api field #1337

Merged
merged 2 commits into from
Dec 19, 2023

Conversation

javadkh2
Copy link
Collaborator

NetworkId and chainId will be extracted from the url params and added to the tx.

@javadkh2 javadkh2 requested a review from alber70g as a code owner December 13, 2023 12:05
Copy link

changeset-bot bot commented Dec 13, 2023

🦋 Changeset detected

Latest commit: d57ade4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@kadena/pactjs-cli Patch
@kadena/graph Patch
@kadena/client-examples Patch
@kadena/client-utils Patch
@kadena/cookbook Patch
@kadena/client Patch
@kadena/pactjs-generator Patch
@kadena/hd-wallet Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
alpha-docs ⬜️ Ignored (Inspect) Visit Preview Dec 19, 2023 10:43am
docs-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 19, 2023 10:43am
proof-of-us ⬜️ Ignored (Inspect) Visit Preview Dec 19, 2023 10:43am
react-ui ⬜️ Ignored (Inspect) Visit Preview Dec 19, 2023 10:43am
tools ⬜️ Ignored (Inspect) Visit Preview Dec 19, 2023 10:43am

@javadkh2 javadkh2 force-pushed the fix/incorrect-networkid branch from 0742cf5 to d57ade4 Compare December 19, 2023 10:41
@javadkh2 javadkh2 merged commit da87410 into main Dec 19, 2023
8 checks passed
@javadkh2 javadkh2 deleted the fix/incorrect-networkid branch December 19, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants