feat(kadena-sdk): refactor transfers for more flexibility (#2767)

* feat(kadena-sdk): refactor transfers for more flexibility * fix(wallet-sdk): add mock and re-enable gettransfer test * fix(wallet-sdk): fix build errors and improve example wallet debugging * fix(wallet-sdk): fix build errors * fix(wallet-sdk): improve test coverage * fix(wallet-sdk-example): update sdk * feat(kadena-sdk): add fungible param to create transfer methods * changeset(wallet-sdk): minor bump --------- Co-authored-by: Bart Huijgen <barthuijgen@users.noreply.github.com>
kadena-community · Jan 28, 2025 · 4e1530d · 4e1530d
1 parent 0deacb4
commit 4e1530d
Show file tree

Hide file tree

Showing 32 changed files with 11,518 additions and 585 deletions.
diff --git a/.changeset/selfish-jokes-yell.md b/.changeset/selfish-jokes-yell.md
@@ -0,0 +1,5 @@
+---
+'@kadena/wallet-sdk': minor
+---
+
+Provide new create transfer methods (breaking change)
diff --git a/packages/apps/wallet-sdk-example/src/App.tsx b/packages/apps/wallet-sdk-example/src/App.tsx
@@ -43,6 +43,7 @@ function App() {
 
   useEffect(() => {
     const transport = (log: ILogObject) => {
+      console.log(log);
       const id = notificationIdCounter.current++;
       const notification: ILogNotification = { ...log, id };
 

diff --git a/packages/apps/wallet-sdk-example/src/components/SdkFunctionDisplayer.tsx b/packages/apps/wallet-sdk-example/src/components/SdkFunctionDisplayer.tsx
@@ -21,7 +21,9 @@ const HighlightBlock: React.FC<{ data: string; language: string }> = ({
 }) => {
   const elRef = useRef<HTMLElement>(null);
   useEffect(() => {
-    if (elRef.current) hljs.highlightElement(elRef.current);
+    if (elRef.current && elRef.current.dataset.highlighted !== 'yes') {
+      hljs.highlightElement(elRef.current);
+    }
   }, []);
   return (
     <pre className={sdkDisplayCode}>

diff --git a/packages/apps/wallet-sdk-example/src/pages/Transfer.tsx b/packages/apps/wallet-sdk-example/src/pages/Transfer.tsx
@@ -24,8 +24,8 @@ import { AlertDialog } from '../components/AlertDialog';
 import { useFunctionTracker } from '../hooks/functionTracker';
 import { useWalletState } from '../state/wallet';
 
-type SimpleCreateTransfer = Parameters<
-  typeof walletSdk.createSimpleTransfer
+type createTransferCreateCommand = Parameters<
+  typeof walletSdk.createTransferCreateCommand
 >[0];
 
 type CrossChainCreateTransfer = Parameters<
@@ -48,8 +48,8 @@ export const Transfer = () => {
     amount: string;
   } | null>(null);
 
-  const trackCreateSimpleTransfer = useFunctionTracker(
-    'walletSdk.createSimpleTransfer',
+  const trackCreateTransferCreateCommand = useFunctionTracker(
+    'walletSdk.createTransferCreateCommand',
   );
   const trackCreateCrossChainTransfer = useFunctionTracker(
     'walletSdk.createCrossChainTransfer',
@@ -90,7 +90,7 @@ export const Transfer = () => {
         targetChainId: wallet.selectedToChain,
       });
     } else {
-      trackCreateSimpleTransfer.setArgs({
+      trackCreateTransferCreateCommand.setArgs({
         amount,
         sender: wallet.account.name,
         receiver: receiverAccount,
@@ -123,6 +123,9 @@ export const Transfer = () => {
         'Cannot perform a cross-chain transfer to the same chain',
       );
     }
+    if (!receiverAccount.startsWith('k:')) {
+      throw new Error('Receiver account must be a k: account');
+    }
 
     let transaction: IUnsignedCommand;
 
@@ -149,15 +152,21 @@ export const Transfer = () => {
       transaction = walletSdk.createCrossChainTransfer(crossChainTransferArgs);
       return await wallet.signTransaction(transaction);
     } else {
-      const functionArgs: SimpleCreateTransfer & { networkId: string } = {
+      const functionArgs: createTransferCreateCommand = {
         amount,
         sender: wallet.account.name,
-        receiver: receiverAccount,
+        receiver: {
+          account: receiverAccount,
+          keyset: {
+            keys: [receiverAccount.split(':')[1]],
+            pred: 'keys-all',
+          },
+        },
         chainId: fromChain,
         networkId: wallet.selectedNetwork,
       };
 
-      transaction = walletSdk.createSimpleTransfer(functionArgs);
+      transaction = walletSdk.createTransferCreateCommand(functionArgs);
       return await wallet.signTransaction(transaction);
     }
   };
@@ -196,7 +205,7 @@ export const Transfer = () => {
 
       /* -- Start demo ---------------*/
       trackGasEstimate.setArgs(null);
-      trackCreateSimpleTransfer.setArgs(null);
+      trackCreateTransferCreateCommand.setArgs(null);
       trackCreateCrossChainTransfer.setArgs(null);
       /* -- End demo ---------------*/
     }
@@ -228,7 +237,7 @@ export const Transfer = () => {
 
       /* -- Start demo ---------------*/
       trackGasEstimate.setArgs(null);
-      trackCreateSimpleTransfer.setArgs(null);
+      trackCreateTransferCreateCommand.setArgs(null);
       trackCreateCrossChainTransfer.setArgs(null);
       /* -- End demo ---------------*/
       navigate('/list');
@@ -350,7 +359,7 @@ export const Transfer = () => {
         data={
           isCrossChain
             ? trackCreateCrossChainTransfer.data
-            : trackCreateSimpleTransfer.data
+            : trackCreateTransferCreateCommand.data
         }
       />
     </div>

diff --git a/packages/apps/wallet-sdk-example/src/pages/Transfers.tsx b/packages/apps/wallet-sdk-example/src/pages/Transfers.tsx
@@ -144,9 +144,9 @@ export const Transfers = () => {
                             ? `-${transfer.amount}`
                             : `+${transfer.amount}`}
                         </Text>
-                        {transfer.transactionFeeTransfer && (
+                        {transfer.transactionFee && (
                           <Text className="text-negative">
-                            {`-${transfer.transactionFeeTransfer.amount}`}
+                            {`-${transfer.transactionFee.amount}`}
                           </Text>
                         )}
                       </Stack>

diff --git a/packages/libs/wallet-sdk/codegen.ts b/packages/libs/wallet-sdk/codegen.ts
@@ -11,6 +11,12 @@ const config: CodegenConfig = {
       config: { useTypeImports: true },
     },
   },
+  config: {
+    scalars: {
+      BigInt: 'number',
+      DateTime: 'string',
+    },
+  },
   hooks: {
     afterAllFileWrite(...files) {
       for (let i = 0; i < files.length; i++) {