-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy staging site on Cloudflare Pages #252
Conversation
Deploying kachick-github-io with
|
Latest commit: |
f9d573a
|
Status: | ✅ Deploy successful! |
Preview URL: | https://0c325d05.kachick-github-io.pages.dev |
Branch Preview URL: | https://cloudflare-pages.kachick-github-io.pages.dev |
Hmm... automatic git integration requires build command, however cloudflare environment does not support deno. (They supports bun!) So requires github action integration as this. However it made conflicts. |
🎉 |
How to expire the preview site? 🤔 https://developers.cloudflare.com/pages/configuration/preview-deployments/ |
I ignored the cleanup problem in this PR 🤷♂️ I will address it after the problem actually appears, I hope then they provide a simple solution... 🙏 |
tree ./dist | ||
- name: Deploy | ||
id: deploy | ||
uses: cloudflare/wrangler-action@6d58852c35a27e6034745c5d0bc373d739014f7f # v3.13.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are they avoiding own action...? 👀 https://github.com/cloudflare/cloudflare-docs/blob/84eb1ed98a6991608742c51cccb64d6339aeb0b5/.github/workflows/publish-preview.yml#L34-L42
I am thinking about the same thing haha, looking for a way to turn down the preview site after a PR is closed/merged |
Resolves GH-91