Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy staging site on Cloudflare Pages #252

Merged
merged 9 commits into from
Jan 8, 2025
Merged

Deploy staging site on Cloudflare Pages #252

merged 9 commits into from
Jan 8, 2025

Conversation

kachick
Copy link
Owner

@kachick kachick commented Jan 8, 2025

Resolves GH-91

Copy link

cloudflare-workers-and-pages bot commented Jan 8, 2025

Deploying kachick-github-io with  Cloudflare Pages  Cloudflare Pages

Latest commit: f9d573a
Status: ✅  Deploy successful!
Preview URL: https://0c325d05.kachick-github-io.pages.dev
Branch Preview URL: https://cloudflare-pages.kachick-github-io.pages.dev

View logs

@kachick
Copy link
Owner Author

kachick commented Jan 8, 2025

Hmm... automatic git integration requires build command, however cloudflare environment does not support deno. (They supports bun!)

So requires github action integration as this. However it made conflicts.

@kachick
Copy link
Owner Author

kachick commented Jan 8, 2025

Adjusted
image

@kachick
Copy link
Owner Author

kachick commented Jan 8, 2025

image

And disable this useful posting comment bot. I prefer commenting via myself 😢

@kachick
Copy link
Owner Author

kachick commented Jan 8, 2025

Copy link
Contributor

github-actions bot commented Jan 8, 2025

@kachick kachick changed the title Attempt preview deploy via clouflare Deploy staging site on Cloudflare Pages Jan 8, 2025
@kachick
Copy link
Owner Author

kachick commented Jan 8, 2025

🎉

@kachick
Copy link
Owner Author

kachick commented Jan 8, 2025

How to expire the preview site? 🤔 https://developers.cloudflare.com/pages/configuration/preview-deployments/

@kachick
Copy link
Owner Author

kachick commented Jan 8, 2025

I ignored the cleanup problem in this PR 🤷‍♂️

I will address it after the problem actually appears, I hope then they provide a simple solution... 🙏

@kachick kachick marked this pull request as ready for review January 8, 2025 12:43
@kachick kachick merged commit 6c9510d into main Jan 8, 2025
9 checks passed
@kachick kachick deleted the cloudflare-pages branch January 8, 2025 12:44
tree ./dist
- name: Deploy
id: deploy
uses: cloudflare/wrangler-action@6d58852c35a27e6034745c5d0bc373d739014f7f # v3.13.0
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moojing
Copy link

moojing commented Feb 4, 2025

I am thinking about the same thing haha, looking for a way to turn down the preview site after a PR is closed/merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deploy preview page
2 participants