Make nvm finally work.

kabalin · Feb 1, 2021 · 786751d · 786751d
1 parent 27be3bf
commit 786751d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -88,6 +88,8 @@ jobs:
         echo "TRAVIS_BUILD_DIR="$(cd ../moodle-local_travis; pwd) >> $GITHUB_ENV
         # PHPUnit depends on en_AU.UTF-8 locale
         sudo locale-gen en_AU.UTF-8
+        # Define NVM_DIR pointing to nvm installation.
+        echo "NVM_DIR=$HOME/.nvm" >> $GITHUB_ENV
 
     - name: Install moodle-plugin-ci
       run: moodle-plugin-ci install -vvv

diff --git a/src/Installer/VendorInstaller.php b/src/Installer/VendorInstaller.php
@@ -102,7 +102,7 @@ public function stepCount()
      */
     public function canInstallNode()
     {
-        return getenv('NVM_DIR') && getenv('NVM_BIN');
+        return !empty(getenv('NVM_DIR'));
     }
 
     /**
-Original file line number
+Diff line change
@@ Expand Up / @@ -102,7 +102,7 @@ public function stepCount() @@
          */
         public function canInstallNode()
         {
-            return getenv('NVM_DIR') && getenv('NVM_BIN');
+            return !empty(getenv('NVM_DIR'));
         }
         /**
@@ Expand Down @@