Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforcing runtimeClassName #39

Merged
merged 6 commits into from
Apr 24, 2021

Conversation

jesmg
Copy link
Contributor

@jesmg jesmg commented Apr 5, 2021

Added "spec.containers.enforcing.runtimeClassName" in Space object.
Setting this property will ensure the given runtimeClassName is used to run all the pods in the Space.

This PR solves #10.

@jesmg jesmg changed the title Runtimeclass definition Enforcing runtimeClassName Apr 5, 2021
@angelbarrera92
Copy link
Member

Hi @jesmg!!! Amazing contribution mate!

Why did you decide to use the enforcing attribute in the CRD to add the runtimeClassName? @paurosello what do you think about the enforcing word?

Apart from the naming convention, I miss some tests and docs, but at the same time, we can contribute them in future releases.

Thanks!

@jesmg
Copy link
Contributor Author

jesmg commented Apr 5, 2021

Why did you decide to use the enforcing attribute in the CRD to add the runtimeClassName? @paurosello what do you think about the enforcing word?

Because we are enforcing a runtimeClassName, not setting a default value (all the containers are forced to run with the specified runtime). I could have added runtimeClassName directly under spec.containers, but I think we will want to add new "enforcing" options in the future.

@paurosello
Copy link
Member

paurosello commented Apr 5, 2021 via email

@jesmg
Copy link
Contributor Author

jesmg commented Apr 22, 2021

Done! :)

@angelbarrera92 angelbarrera92 merged commit 732a90c into k8spin:master Apr 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants