-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforcing runtimeClassName #39
Conversation
Without this change, the latest public version of the image is going to be deployed, avoiding to test new changes.
Hi @jesmg!!! Amazing contribution mate! Why did you decide to use the Apart from the naming convention, I miss some tests and docs, but at the same time, we can contribute them in future releases. Thanks! |
Because we are enforcing a runtimeClassName, not setting a default value (all the containers are forced to run with the specified runtime). I could have added |
I am fine with setting it in a different attribute but I would set it to
"enforce" not "enforcing", otherwise seems good to me.
Missatge de Jesús ***@***.***> del dia dl., 5 d’abr. 2021 a
les 10:10:
… Why did you decide to use the enforcing attribute in the CRD to add the
runtimeClassName? @paurosello <https://github.com/paurosello> what do you
think about the enforcing word?
Because we are *enforcing* a runtimeClassName, not setting a default
value (all the containers are forced to run with the specified runtime). I
could have added runtimeClassName directly under spec.containers, but I
think we will want to add new "enforcing" options in the future.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#39 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIU3AQLC6JZXGDEFF3LCQDTHFV6PANCNFSM42MKNH3Q>
.
|
Done! :) |
Added "spec.containers.enforcing.runtimeClassName" in Space object.
Setting this property will ensure the given runtimeClassName is used to run all the pods in the Space.
This PR solves #10.