cluster: Allow kubevirtci tag overriding #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
It is helpful either manually or for example when used from CNAO, to use same tag of the cluster that CNAO deployed. Otherwise a kubevirtci tag mismatch can cause failures once running from CNAO. Signed-off-by: Or Shoval <oshoval@redhat.com>
Previous method doesnt support newer versions anymore (or not at least atm). Just use wget instead. Signed-off-by: Or Shoval <oshoval@redhat.com>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oshoval, phoracek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Nov 23, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
It is helpful either manually or for example
when used from CNAO, to use same tag of the cluster that CNAO deployed.
Otherwise a kubevirtci tag mismatch can cause failures once running OVS e2e tests from CNAO.
Beside that fix go download, as the previous method doesn't work anymore.
https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/k8snetworkplumbingwg_ovs-cni/319/pull-e2e-ovs-cni/1808463231954456576#1:build-log.txt%3A9859
go.mod was changed to fit the new download mechanism,
but anyhow lately this is common on all repos to add the patch, i.e kubevirt as well
that was changed lately https://github.com/kubevirt/kubevirt/blob/a3b2bf3a54936b3dedf1341f6927ba6bdda51557/go.mod#L210
This semantic is allowed, and even required when the toolchain arg will present.
Special notes for your reviewer:
Release note: