e2e, Merge k8s clients #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdb5276 to
c78b59c
Compare
560861d to
58a1f2b
Compare
This bump also requires other package bumps like multus-cni, and kubevirt/client-go Also adding vendor --compat option to Makefile Signed-off-by: Ram Lavi <ralavi@redhat.com>
custom reporters currently give no added value. Removing from test suite. Signed-off-by: Ram Lavi <ralavi@redhat.com>
This flag is no longer supported. Refactoring test args and removing junit-output flag Signed-off-by: Ram Lavi <ralavi@redhat.com>
Introducing a new kubecli virt client to the testClient object. Signed-off-by: Ram Lavi <ralavi@redhat.com>
Currently e2e tests use 2 different clientsets to configure the cluster (kubeclient and virt client) - both are old. Moving to use the up to date kubecli virt client. In most places the api was changes with no other modifications, but in specific places minor changes were made Signed-off-by: Ram Lavi <ralavi@redhat.com>
in the current Kubevirt client the dry-run for VM create is not yet implemented. Moving this test temporarily to pending. Signed-off-by: Ram Lavi <ralavi@redhat.com>
58a1f2b to
206885d
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qinqon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Right now kubemacpool is using 2 separate kubeclients to conduct the e2e tests. These are pretty old. Moving to the latest kubevirt client for better use.
Special notes for your reviewer:
Release note: