Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to CLI flag grouping + deprecated flag warnings. #5937

Merged
merged 5 commits into from
Aug 2, 2022
Merged

Updates to CLI flag grouping + deprecated flag warnings. #5937

merged 5 commits into from
Aug 2, 2022

Conversation

dereknola
Copy link
Member

@dereknola dereknola commented Aug 2, 2022 •
edited by brandond
Loading

Proposed Changes

  • When updating the K3s docs, I noticed several inconsistencies in the spelling and grouping of K3s flags. These have been fixed
  • Previously deprecated flags have been hidden and a warning has been added to each that informs the user of their removal in v1.25

Types of Changes

Verification

k3s server -h
-cluster-secret --no-flannel and no-deploy now shows a warning log on startup the k3s server

Testing

N/A

Linked Issues

#6110

User-Facing Change

Deprecated flags now warn of their v1.25 removal

Further Comments

@dereknola
Consolidate data dir flag
7429b90 
Signed-off-by: Derek Nola <derek.nola@suse.com>
@dereknola
Group cluster flags together
94869c7 
Signed-off-by: Derek Nola <derek.nola@suse.com>
@dereknola
Reorder and group agent flags
c944d34 
Signed-off-by: Derek Nola <derek.nola@suse.com>
@dereknola
Add additional info around vmodule flag
887bd3b 
Signed-off-by: Derek Nola <derek.nola@suse.com>
@dereknola
Hide deprecated flags, and add warning about their removal
d6aa277 
Signed-off-by: Derek Nola <derek.nola@suse.com>
@dereknola dereknola requested a review from a team as a code owner August 2, 2022 17:30
@dereknola dereknola merged commit 118a68c into k3s-io:master Aug 2, 2022
@dereknola dereknola deleted the fix-cli branch August 8, 2022 17:20
@cguertin14 cguertin14 mentioned this pull request Aug 26, 2022
Merged
nikolaishields pushed a commit to nikolaishields/k3s that referenced this pull request Sep 14, 2022
@dereknola @nikolaishields
Updates to CLI flag grouping + deprecated flag warnings. (k3s-io#5937)
352d004 
* Consolidate data dir flag
* Group cluster flags together
* Reorder and group agent flags
* Add additional info around vmodule flag
* Hide deprecated flags, and add warning about their removal

Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Nikolai Shields <nikolai@nikolaishields.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandond brandond brandond approved these changes

@briandowns briandowns briandowns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dereknola @brandond @briandowns