Add service-cluster-ip-range to controller-manager args #5894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briandowns
approved these changes
Jul 21, 2022
dereknola
approved these changes
Jul 21, 2022
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
2896468 to
848b314
Compare
Requires tweaking existing method signature to allow specifying whether or not IPv6 addresses should be return URL-safe. Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
|
CI is green other than s390x (down due to hardware issues) and a flake. Merging. |
This was referenced Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Add service-cluster-ip-range to controller-manager args.
Also replace getLocalhostIP with Loopback helper method.
note: This does not absolve users from having to manually correct the node-cidr-mask values if they reduce the cluster cidrs below the default sizes. This only addresses the argument being missing from the controller-manager.
Types of Changes
bugfix
Verification
See linked issue
Testing
Linked Issues
User-Facing Change
Further Comments