Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.23] backport fixes for egress proxy, servicelb, and kine issues #5797

Merged
merged 3 commits into from
Jul 1, 2022
Merged

[release-1.23] backport fixes for egress proxy, servicelb, and kine issues #5797

merged 3 commits into from
Jul 1, 2022

Conversation

brandond
Copy link
Member

@brandond brandond commented Jul 1, 2022 •
edited
Loading

Proposed Changes

Backports:

Types of Changes

bugfix / backport

Verification

See linked issues

Testing

n/a

Linked Issues

User-Facing Change

Fixed an issue that prevented `kubectl logs` and other functionality that requires a connection to the agent from working correctly when the server's `--bind-address` flag was used, or when K3s is used behind a HTTP proxy.
K3s will no longer log panics after upgrading directly from much older Kubernetes releases, or when deploying services with `type: ExternalName`.
Bumped kine to v0.9.3

Further Comments

brandond added 3 commits July 1, 2022 09:24
@brandond
Fix egress selector proxy/bind-address support
e26318d 
Use same kubelet-preferred-address-types setting as RKE2 to improve reliability of the egress selector when using a HTTP proxy. Also, use BindAddressOrLoopback to ensure that the correct supervisor address is used when --bind-address is set.

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
@brandond
Don't crash when service IPFamiliyPolicy is not set
ac10d1b 
Service.Spec.IPFamilyPolicy may be a nil pointer on freshly upgraded clusters.

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
@brandond
Bump kine to v0.9.3
5c029ff 
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
@brandond brandond requested a review from a team as a code owner July 1, 2022 16:28
@brandond brandond merged commit fe3cecc into k3s-io:release-1.23 Jul 1, 2022
@brandond brandond deleted the egress-servicelb-backports_release-1.23 branch June 6, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galal-hussein galal-hussein galal-hussein approved these changes

@dereknola dereknola dereknola approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brandond @galal-hussein @dereknola