Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

タグのバージョン変更で規格外のデータに変換されるらしい #8

Closed
k-takata opened this issue May 2, 2017 · 3 comments

Comments

@k-takata
Copy link
Owner

k-takata commented May 2, 2017

http://kbmplaybbs.dip.jp/?md=tv&pn=5675&ln=1

  ・以下の場合に規格外のデータに変換されていた
   ・ID3v2.2 => ID3v2.3
   ・ID3v2.2 => ID3v2.4
   ・ID3v2.3 => ID3v2.2
   ・ID3v2.4 => ID3v2.2
   ・変換後、埋め込み画像対応のソフトで画像が表示されなくなっていた
  ・↑の規格外フレームが存在する場合は、タグの更新時に修正するようにした
  ・STEP_M/mp3infp にも同じバグが存在

@k-takata
Copy link
Owner Author

k-takata commented May 2, 2017

http://kbmplaybbs.dip.jp/?md=ov&no=5683&pn=5675&ln=1

1.02 正式版でソースコード公開したら mp3infp/u の方でも反映されると
良いんですけど…。

@k-takata
Copy link
Owner Author

ID3v2.2 とそれ以降では、Attached picture のフレーム構造が異なる。

  • ID3v2.2 "PIC"

    Text encoding      $xx
    Image format       $xx xx xx
    Picture type       $xx
    Description        <textstring> $00 (00)
    Picture data       <binary data>
    
  • ID3v2.3, ID3v2.4 "APIC"

    Text encoding      $xx
    MIME type          <text string> $00
    Picture type       $xx
    Description        <text string according to encoding> $00 (00)
    Picture data       <binary data>
    

k-takata added a commit that referenced this issue Jan 30, 2018
Mp3infp didn't convert APIC frame properly when changing the tag version
between v2.2 and v2.3/2.4.  The frame formats are different between
them.  Convert them properly.
k-takata added a commit that referenced this issue Jan 31, 2018
Mp3infp didn't convert APIC frame properly when changing the tag version
between v2.2 and v2.3/2.4.  The frame formats are different between
them.  Convert them properly.
k-takata added a commit that referenced this issue Jan 31, 2018
Mp3infp didn't convert APIC frame properly when changing the tag version
between v2.2 and v2.3/2.4.  The frame formats are different between
them.  Convert them properly.
@k-takata
Copy link
Owner Author

k-takata commented Feb 3, 2018

Fixed in 2.55 beta1.

@k-takata k-takata closed this as completed Feb 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant