Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix in variable density implementation #113

Merged
merged 1 commit into from
Apr 1, 2024
Merged

bug fix in variable density implementation #113

merged 1 commit into from
Apr 1, 2024

Conversation

jzmejia
Copy link
Owner

@jzmejia jzmejia commented Apr 1, 2024

fix to Crevasse.paterson_empirical_relation(), added check to accepted depth array to ensure positive values.

This commit closes #112

A new problem has emerged in executing IceBlock.increment_time() in Crevasse.evolve_crevasses()

ib=IceBlock(1140,
            1, 
            dt=1, 
            years_to_run=2,
            thermal_freq=365,
            crev_spacing=56,
            u_surf=200,
            T_profile=pd.read_csv('crevprop/data/foxxTemperatureProfile.csv',
            names=['t','z']),
            sigmaT0=128e3,
            creep_table=df,
            include_creep=True,
            Qin_annual=1000,
            shear_modulus=1e8,
            initial_crev_depth=40.2
           )

crevasse = ib.crev_field.crev_instances[0]

ib.increment_time()

Produces the following Error Messages
Screenshot 2024-04-01 at 2 53 22 PM

Error resolved for Qin_annual = 5000 and a crevasse evolution as follows is produced.
The issue here is that water height goes to 0 and remains there on day 22 and afterward.
Screenshot 2024-04-01 at 3 10 28 PM

@jzmejia jzmejia added the fix fixes label Apr 1, 2024
@jzmejia jzmejia self-assigned this Apr 1, 2024
@jzmejia jzmejia merged commit af57733 into main Apr 1, 2024
@jzmejia jzmejia deleted the driver branch April 1, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Variable density for firn layer enhancement
1 participant