bug fix in variable density implementation #113
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix to
Crevasse.paterson_empirical_relation()
, added check to accepted depth array to ensure positive values.This commit closes #112
A new problem has emerged in executing
IceBlock.increment_time()
inCrevasse.evolve_crevasses()
Produces the following Error Messages
Error resolved for Qin_annual = 5000 and a crevasse evolution as follows is produced.
The issue here is that water height goes to 0 and remains there on day 22 and afterward.