fix(bar-chart): change legend padding for horizontal orientation (apa…

…che#27883)
jzhao62 · Apr 4, 2024 · 94b6b76 · 94b6b76
1 parent 8d4ab21
commit 94b6b76
Showing 1 changed file with 11 additions and 2 deletions.
diff --git a/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformers.ts b/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformers.ts
@@ -563,15 +563,24 @@ export function getPadding(
     ? TIMESERIES_CONSTANTS.yAxisLabelTopOffset
     : 0;
   const xAxisOffset = addXAxisTitleOffset ? Number(xAxisTitleMargin) || 0 : 0;
+  const showLegendTopOffset =
+    isHorizontal && showLegend && legendOrientation === LegendOrientation.Top
+      ? 100
+      : 0;
+
   return getChartPadding(
     showLegend,
     legendOrientation,
     margin,
     {
       top:
         yAxisTitlePosition && yAxisTitlePosition === 'Top'
-          ? TIMESERIES_CONSTANTS.gridOffsetTop + (Number(yAxisTitleMargin) || 0)
-          : TIMESERIES_CONSTANTS.gridOffsetTop + yAxisOffset,
+          ? TIMESERIES_CONSTANTS.gridOffsetTop +
+            showLegendTopOffset +
+            (Number(yAxisTitleMargin) || 0)
+          : TIMESERIES_CONSTANTS.gridOffsetTop +
+            showLegendTopOffset +
+            yAxisOffset,
       bottom:
         zoomable && !isHorizontal
           ? TIMESERIES_CONSTANTS.gridOffsetBottomZoomable + xAxisOffset