make dependencies part of makefile #40
Comments
|
A virtualenv[1] would be the way to do this... I for one would be annoyed if I downloaded a repo and `make` started making changes to my environment without asking (as opposed to `make install` or something).
1 - https://iamzed.com/2009/05/07/a-primer-on-virtualenv/
… On Jun 24, 2018, at 5:46 PM, Joshua Nelson ***@***.***> wrote:
This would lower the burden on the end user and also simplify travis builds slightly. The only difficult thing would be to install in both a system environment (/usr/bin/pip) and virtualenv. pip install --user does not work in a virtual environment.
I'm open to suggestions :)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Hmm, fair. I'll look into it. |
This reverts commit a49c03c. See #40 (comment) for context; `make` shouldn't touch anything but the current directory.
|
how would you expect it to behave if you were already in a virtualenv? Is it possible to nest them? |
|
I don't think so... if I was already in a virtualenv I would want it to just do it’s thing into that virtualenv.
… On Jun 24, 2018, at 6:28 PM, Joshua Nelson ***@***.***> wrote:
how would you expect it to behave if you were already in a virtualenv? Is it possible to nest them?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
There doesn't appear to be a way to source a virtual environment for all recipies in a makefile, we'd have to do it for each individually. The closest we could get is a wrapper for make, similar to |
|
Pushing my current code so you have it available, but I'm a little dubious about this. It might be better to remove dependencies from the makefile altogether. |
|
That’s what I would suggest. I am under the impression that it is a pretty standard python development workflow to setup your virtualenv and install your dependencies via setup.py. If the user finds
source /some/virtualenv/bin/activate
python setup.py install
Too onerous, they can script it themselves.
… On Jun 24, 2018, at 7:16 PM, Joshua Nelson ***@***.***> wrote:
Pushing my current code so you have it available, but I'm a little dubious about this. It might be better to remove dependencies from the makefile altogether.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
got it, you can pass ENV and BASH_ENV to sh and bash respectively and they'll source that on startup |
|
err . . . so we don't think this was a helpful thing to do? I don't really care either way since I only have to install once, I just feel a little silly that I spent time on it |
|
done in 0451585 |
This would lower the burden on the end user and also simplify travis builds slightly. The only difficult thing would be to install in both a system environment (
/usr/bin/pip) and virtualenv.pip install --userdoes not work in a virtual environment.I'm open to suggestions :)
The text was updated successfully, but these errors were encountered: