Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Key strength assertions during signing and verification #367

Merged
merged 1 commit into from
Jul 27, 2018
Merged

Key strength assertions during signing and verification #367

merged 1 commit into from
Jul 27, 2018

Conversation

lhazlewood
Copy link
Contributor

Resolves #334

@lhazlewood lhazlewood added this to the 0.10.0 milestone Jul 27, 2018
@lhazlewood lhazlewood force-pushed the 334-key-length-assertions branch from 5d8f845 to 9189253 Compare July 27, 2018 19:17
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 9189253 on 334-key-length-assertions into 45f83d0 on master.

@lhazlewood lhazlewood merged commit 711d0d5 into master Jul 27, 2018
@lhazlewood lhazlewood deleted the 334-key-length-assertions branch July 27, 2018 19:27
rtyley added a commit to guardian/play-googleauth that referenced this pull request Jul 4, 2024
@rtyley
Avoid deprecated jjwt methods for signing & parsing
e9f2e6b 
* `signWith()` & `setSigningKey()` now prefer to be handed a `Key` type rather than a base64-encoded
String - deprecated in jwtk/jjwt#341
* To obtain a configured `JwtParser`, a builder is now preferred, ie
  `Jwts.parserBuilder().setSigningKey(key).build()` rather than `Jwts.parser().setSigningKey(key)` - deprecated
  in jwtk/jjwt#486
* Use `io.jsonwebtoken.security.SignatureException` rather than
  `io.jsonwebtoken.SignatureException` - deprecated in jwtk/jjwt#367

Note that `play-googleauth` currently supports two versions of Play:

* Play v2.9, uses jjwt v0.11.5
* Play v3.0, uses jjwt v0.12.6

...we need to support both, but thankfully everything we're using is supported in both versions of jjwt.
@rtyley rtyley mentioned this pull request Jul 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@lhazlewood @coveralls