Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(svg) prevent breaking in IE8 #16

Merged
merged 1 commit into from
Apr 12, 2016
Merged

Conversation

rodneyrehm
Copy link
Contributor

IE8 (and below) does not support SVG at all. This would lead to the error Object doesn't support this method or property being thrown.

@jwilsson
Copy link
Owner

Thank you!

I'm thinking I'll revert abd3e01 and tag a new version tomorrow morning (CET) unless you disagree. As we talked about in #12, we wouldn't want to support this in its current state.

I know you didn't want to be a maintainer of this, but I'll be more than happy to add you as a collaborator if you want to? But I'll still help maintain it, publish on npm etc.

@rodneyrehm
Copy link
Contributor Author

I'm thinking I'll revert abd3e01 and tag a new version tomorrow morning […]

that'll remove the existing UMD file altogether, right? I'll have to stick to my fork in that case. But a new release is appreciated either way ;)

I know you didn't want to be a maintainer of this, but I'll be more than happy to add you as a collaborator if you want to? But I'll still help maintain it, publish on npm etc.

My approach to building and providing software is slightly different from yours. I'd rather fork your repositroy, rework the things I'd like them to be, and then we can talk about how to continue from there.

For instance, I'd try to make this work for @bkardell's asTokenlist() proposal (for which this shim did not seem to work well).

@jwilsson
Copy link
Owner

that'll remove the existing UMD file altogether, right? I'll have to stick to my fork in that case. But a new release is appreciated either way ;)

Yes, exactly.

My approach to building and providing software is slightly different from yours. I'd rather fork your repositroy, rework the things I'd like them to be, and then we can talk about how to continue from there.

Alright, no worries! :)

A 1.2.0 is coming right up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants