Fix/non browser environment #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool! I read about ally.js the other week, glad to see some real world usage 😄 Wrapping it with UMD is definitely something I'm interested in, I'm just a bit worried about the extra bytes it brings. I'll open up a new issue for discussion on that. But the patch looks good, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use this module in ally.js and have come across a problem (medialize/ally.js#92) when loading domtokenlist-shim in an environment other than a browser (Node, WebWorker, …). The module doesn't have to do anything in these environments, it should just not throw any errors because
windowdoesn't exist. By addingtypeof window != 'undefined' &&to your IIFEs, the module does not execute in Node.This is PR a quick-n-dirty "fix" and the following is likely a different issue: We may want to use
src/DOMTokenList.jsseparately of the DOM. To make that possible, the module needs to be wrapped in UMD and return the object, rather than assign it to window. Is that something you could agree to?