Skip to content

Commit

Permalink
feat!: Alter name of base dev container image
Browse files Browse the repository at this point in the history
Updates the dev container name built for this project to align with new standard. This makes it so the default dev container image name is distinct from the project in case it also builds Docker images.
  • Loading branch information
jwbennet committed Feb 8, 2024
1 parent c629ceb commit b1b26e6
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "Project Base",
"image": "ghcr.io/jwbennet/project-base:latest",
"image": "ghcr.io/jwbennet/project-base-dev-container:latest",
"postCreateCommand": "task setup"
}
2 changes: 1 addition & 1 deletion .github/workflows/devcontainer-build-and-push.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
uses: devcontainers/ci@v0.3
with:
subFolder: .github
imageName: ghcr.io/${{ github.repository }}
imageName: ghcr.io/${{ github.repository }}-dev-container
imageTag: "${{ steps.image.outputs.IMAGE_TAGS }}"
cacheFrom: ghcr.io/${{ github.repository }}
push: always
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,6 @@
}
}
{%- else %}
"image": "ghcr.io/jwbennet/project-base:latest"
"image": "ghcr.io/jwbennet/project-base-dev-container:latest"
{%- endif %}
}

0 comments on commit b1b26e6

Please sign in to comment.