Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add __all__ to __init__.py #31

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

ThirVondukr
Copy link
Contributor

Implicitly re-export archrule in __init__.py, this is generally a good practice and some linters require that (flake8/ruff and mypy)

@jwbargsten
Copy link
Owner

I checked it shortly, and indeed it seems to be considered best practice

To better support introspection, modules should explicitly declare the names in their public API using the all attribute. Setting all to an empty list indicates that the module has no public API.

so LGTM

@jwbargsten jwbargsten merged commit cdee7ab into jwbargsten:main Dec 5, 2023
4 checks passed
@jwbargsten
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants