Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.1.0 #5

Merged
merged 3 commits into from
Oct 27, 2017
Merged

1.1.0 #5

merged 3 commits into from
Oct 27, 2017

Conversation

ahmader
Copy link
Contributor

@ahmader ahmader commented Oct 18, 2017

  • Pass optional query parameters to Wufoo API.
  • Update request npm version.
  • Updated README.
  • Adding tests for new feature.

ahmader and others added 3 commits July 5, 2014 23:03
@ahmader
Adding params to functions
84158f9 
Because in some cases to (use Filters, show System fields) we need the
URI to deal with optional params variable.
For example:
Wufoo.getFormEntries(id, params, fn)
Wufoo.getFormEntries(id, fn)
both works
@ahmader
1.1.0
4bb7b76 
- Pass optional query parmaters to Wufoo API.
- Update request npm version.
- Updated README.
- Adding tests for new feature.
@ahmader
Merge branch 'master' into 1.1.0
3b6cb2a
@ahmader ahmader mentioned this pull request Oct 18, 2017
Merged
@jusx
Copy link
Owner

jusx commented Oct 27, 2017

@ahmader Thanks. The tests a failing but that is due to Wufoo.request method not properly sending the params as query string. I will fix that separately and go ahead and merge this in.

@jusx jusx merged commit 64f5d5b into jusx:master Oct 27, 2017
@ahmader ahmader deleted the 1.1.0 branch January 28, 2018 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahmader @jusx