Merge pull request kubernetes-sigs#212 from shawn-hurley/issue/202-1

Set GVK when getting the object from the cache.
justinsb · Nov 21, 2018 · fb069ac · fb069ac
2 parents 3bdfa82 + 857c2e6
commit fb069ac
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/pkg/cache/cache_test.go b/pkg/cache/cache_test.go
@@ -89,6 +89,13 @@ var _ = Describe("Informer Cache", func() {
 		knownPod1 = createPod("test-pod-1", testNamespaceOne, kcorev1.RestartPolicyNever)
 		knownPod2 = createPod("test-pod-2", testNamespaceTwo, kcorev1.RestartPolicyAlways)
 		knownPod3 = createPod("test-pod-3", testNamespaceTwo, kcorev1.RestartPolicyOnFailure)
+		podGVK := schema.GroupVersionKind{
+			Kind:    "Pod",
+			Version: "v1",
+		}
+		knownPod1.GetObjectKind().SetGroupVersionKind(podGVK)
+		knownPod2.GetObjectKind().SetGroupVersionKind(podGVK)
+		knownPod3.GetObjectKind().SetGroupVersionKind(podGVK)
 
 		By("creating the informer cache")
 		var err error

diff --git a/pkg/cache/internal/cache_reader.go b/pkg/cache/internal/cache_reader.go
@@ -81,6 +81,7 @@ func (c *CacheReader) Get(_ context.Context, key client.ObjectKey, out runtime.O
 		return fmt.Errorf("cache had type %s, but %s was asked for", objVal.Type(), outVal.Type())
 	}
 	reflect.Indirect(outVal).Set(reflect.Indirect(objVal))
+	out.GetObjectKind().SetGroupVersionKind(c.groupVersionKind)
 
 	return nil
 }