Fixes for toLocalDateTime in Date and Time types

* Use `toDateTime` instead of old `withXXX()` * Make time arg optional in `Date.prototype.toLocalDateTime`
justingrant · Oct 11, 2020 · cf9d55c · cf9d55c
1 parent d330883
commit cf9d55c
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/polyfill/index.d.ts b/polyfill/index.d.ts
@@ -433,7 +433,7 @@ export namespace Temporal {
     ): Temporal.Duration;
     toLocalDateTime(
       tzLike: TimeZoneProtocol | string,
-      temporalTime: Temporal.Time,
+      temporalTime?: Temporal.Time,
       options?: ToAbsoluteOptions
     ): Temporal.LocalDateTime;
     toDateTime(temporalTime: Temporal.Time): Temporal.DateTime;

diff --git a/polyfill/lib/date.mjs b/polyfill/lib/date.mjs
@@ -214,8 +214,8 @@ export class Date {
   }
   toLocalDateTime(temporalTimeZoneLike, temporalTime, options) {
     if (!ES.IsTemporalDate(this)) throw new TypeError('invalid receiver');
-    // TODO: switch to `toDateTime()` after that lands
-    const dateTime = this.withTime(temporalTime);
+    const TemporalTime = GetIntrinsic('%Temporal.Time%');
+    const dateTime = this.toDateTime(temporalTime === undefined ? TemporalTime.from('00:00') : temporalTime);
     const TemporalTimeZone = GetIntrinsic('%Temporal.TimeZone%');
     const timeZone = TemporalTimeZone.from(temporalTimeZoneLike);
     const TemporalLocalDateTime = GetIntrinsic('%Temporal.LocalDateTime%');

diff --git a/polyfill/lib/time.mjs b/polyfill/lib/time.mjs
@@ -388,8 +388,7 @@ export class Time {
   }
   toLocalDateTime(temporalTimeZoneLike, temporalDate, options) {
     if (!ES.IsTemporalTime(this)) throw new TypeError('invalid receiver');
-    // TODO: switch to `toDateTime()`
-    const dateTime = this.withDate(temporalDate);
+    const dateTime = this.toDateTime(temporalDate);
     const TemporalTimeZone = GetIntrinsic('%Temporal.TimeZone%');
     const timeZone = TemporalTimeZone.from(temporalTimeZoneLike);
     const TemporalLocalDateTime = GetIntrinsic('%Temporal.LocalDateTime%');