Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Moq #531

Merged
merged 2 commits into from
Aug 9, 2023
Merged

Conversation

martincostello
Copy link
Member

@martincostello martincostello commented Aug 9, 2023

  • Remove Moq and replace with NSubstitute.
  • Fix a bug masked by Moq where we were sending empty buckets.
  • Use C#10, rather than 11, to resolve warnings I don't know how to fix related to the new scoped keyword (see Update to .NET 7 #374 (comment)).

Remove Moq and replace with NSubstitute.
Use C#10, rather than 11, to resolve warnings I don't know how to fix about scope of ref variables.
@martincostello martincostello added enhancement dependencies Pull requests that update a dependency file .NET Pull requests that update .NET code labels Aug 9, 2023
@martincostello martincostello requested a review from a team as a code owner August 9, 2023 12:30
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #531 (9a02163) into main (b5a1302) will decrease coverage by 0.17%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #531      +/-   ##
==========================================
- Coverage   95.04%   94.88%   -0.17%     
==========================================
  Files          27       27              
  Lines         606      606              
==========================================
- Hits          576      575       -1     
- Misses         30       31       +1     
Flag Coverage Δ
linux 94.55% <100.00%> (-0.50%) ⬇️
macos 94.55% <100.00%> (-0.34%) ⬇️
windows 94.05% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...tEat.StatsD/Buffered/BufferBasedStatsDPublisher.cs 93.93% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@martincostello martincostello merged commit 6a01daa into justeattakeaway:main Aug 9, 2023
@martincostello martincostello deleted the remove-moq branch August 9, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug dependencies Pull requests that update a dependency file enhancement .NET Pull requests that update .NET code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants