Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deterministics builds #343

Merged

Conversation

martincostello
Copy link
Member

  • Set ContinuousIntegrationBuild in CI.
  • Remove workaround for Sourcelink that should be redundant now.

Set ContinuousIntegrationBuild in CI.
Remove workaround for Sourcelink that should be redundant now.
@martincostello martincostello added this to the v5.0.0 milestone Jul 12, 2021
@martincostello martincostello requested a review from a team as a code owner July 12, 2021 17:22
@codecov
Copy link

codecov bot commented Jul 12, 2021

Codecov Report

Merging #343 (22058c0) into main (7f97e6d) will decrease coverage by 0.45%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #343      +/-   ##
==========================================
- Coverage   94.45%   93.99%   -0.46%     
==========================================
  Files          27       27              
  Lines         883      883              
==========================================
- Hits          834      830       -4     
- Misses         49       53       +4     
Flag Coverage Δ
linux 93.65% <ø> (ø)
macos 93.54% <ø> (-0.46%) ⬇️
windows 93.99% <ø> (+0.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/JustEat.StatsD/ConnectedSocketPool.cs 81.53% <0.00%> (-6.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f97e6d...22058c0. Read the comment docs.

@martincostello martincostello merged commit 1c996e8 into justeattakeaway:main Jul 12, 2021
@martincostello martincostello deleted the Deterministics-Builds branch July 12, 2021 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant