Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

- Test parseEpisodeDetails #96

Merged
merged 4 commits into from
Oct 25, 2021
Merged

- Test parseEpisodeDetails #96

merged 4 commits into from
Oct 25, 2021

Conversation

Bhyan
Copy link
Contributor

@Bhyan Bhyan commented Oct 23, 2021 •
edited
Loading

All tests implemented from the Parse.class. #33

Captura de tela de 2021-10-23 16-40-11

I couldn't test the exception route, if you have any idea how to test it thanks, as all the values passed to the function result in the same answer, null.

Ps.: This screenshot not have the test of parseGenresAnimeJson, because is in another branch.

justdvnsh
justdvnsh requested changes Oct 24, 2021
View reviewed changes
Copy link
Owner

@justdvnsh justdvnsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Bhyan Please resolve the merge conflicts. The code however looks good to me.

justdvnsh
justdvnsh approved these changes Oct 25, 2021
View reviewed changes
Copy link
Owner

@justdvnsh justdvnsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Bhyan LGTM. Thanks for the contributions

@justdvnsh justdvnsh added hacktoberfest-accepted Attached when pr is ready to merge and can be counted for hacktoberfest. ready-to-merge attached when a pr is ready to be merged Test Label when the issue is to write a test. labels Oct 25, 2021
@justdvnsh justdvnsh merged commit b6ad82a into justdvnsh:develop Oct 25, 2021
@Bhyan Bhyan deleted the parseEpisodeDetailsTest branch October 25, 2021 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justdvnsh justdvnsh justdvnsh approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Attached when pr is ready to merge and can be counted for hacktoberfest. ready-to-merge attached when a pr is ready to be merged Test Label when the issue is to write a test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bhyan @justdvnsh