Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issues regarding the next and previous episode buttons #93

Conversation

pauliancu97
Copy link
Contributor

Disable previous/next episode button while episode is loading.
Fixed bug of previos/next episode button's visibility not being updated correctly.

…ng updated correctly, disable next and previous buttons while episode is loading
Copy link
Owner

@justdvnsh justdvnsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI @pauliancu97 Can you please attach a screen recorded video of the functionality. Thanks

@pauliancu97
Copy link
Contributor Author

Here is a screen recording with how the buttons are in this PR:
https://user-images.githubusercontent.com/32488931/138558598-124e0994-c6a1-4f40-a57b-96b3c0868713.mp4

Copy link
Owner

@justdvnsh justdvnsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @pauliancu97 LGTM. Thanks for the contributions

@justdvnsh justdvnsh merged commit 3875809 into justdvnsh:develop Oct 25, 2021
@justdvnsh justdvnsh added hacktoberfest-accepted Attached when pr is ready to merge and can be counted for hacktoberfest. ready-to-merge attached when a pr is ready to be merged UI-change Label to put if there is any UI change labels Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Attached when pr is ready to merge and can be counted for hacktoberfest. ready-to-merge attached when a pr is ready to be merged UI-change Label to put if there is any UI change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants