Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test parseRecentReleaseJson #92

Merged
merged 1 commit into from
Oct 23, 2021
Merged

Test parseRecentReleaseJson #92

merged 1 commit into from
Oct 23, 2021

Conversation

Bhyan
Copy link
Contributor

@Bhyan Bhyan commented Oct 20, 2021

All tests implemented from the Parse.class. #30

And i add new asserts in old tests, can you see in commit.

Captura de tela de 2021-10-20 20-35-54

justdvnsh
justdvnsh approved these changes Oct 21, 2021
View reviewed changes
Copy link
Owner

@justdvnsh justdvnsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI @Bhyan LGTM. Thanks for the contributions

@justdvnsh justdvnsh added hacktoberfest-accepted Attached when pr is ready to merge and can be counted for hacktoberfest. ready-to-merge attached when a pr is ready to be merged Test Label when the issue is to write a test. UI-change Label to put if there is any UI change labels Oct 21, 2021
@justdvnsh justdvnsh merged commit 758a656 into justdvnsh:develop Oct 23, 2021
@Bhyan Bhyan deleted the parseRecentReleaseJsonTest branch October 25, 2021 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justdvnsh justdvnsh justdvnsh approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Attached when pr is ready to merge and can be counted for hacktoberfest. ready-to-merge attached when a pr is ready to be merged Test Label when the issue is to write a test. UI-change Label to put if there is any UI change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bhyan @justdvnsh