Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

talk_to_us button added #85

Merged
merged 3 commits into from
Oct 15, 2021
Merged

talk_to_us button added #85

merged 3 commits into from
Oct 15, 2021

Conversation

AdiAr11
Copy link
Contributor

@AdiAr11 AdiAr11 commented Oct 15, 2021

I've added Talk To Us button addressing issue #76

@AdiAr11
Copy link
Contributor Author

AdiAr11 commented Oct 15, 2021

video demo showing functionality of talk to us button

talk_to_us.mp4

justdvnsh
justdvnsh requested changes Oct 15, 2021
View reviewed changes
Copy link
Owner

@justdvnsh justdvnsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me @AdiAr11 . Please resolve the merge conflicts too. Thank you for your contributions.

@AdiAr11
Copy link
Contributor Author

AdiAr11 commented Oct 15, 2021

Resolved the conflicts. Hope its fine now. Thank you

justdvnsh
justdvnsh approved these changes Oct 15, 2021
View reviewed changes
Copy link
Owner

@justdvnsh justdvnsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AdiAr11 LGTM. Thank you for your contributions. Thanks

@justdvnsh justdvnsh merged commit ff3318d into justdvnsh:develop Oct 15, 2021
@AdiAr11 AdiAr11 deleted the talk_to_us branch October 15, 2021 18:09
@AdiAr11
Copy link
Contributor Author

AdiAr11 commented Oct 15, 2021

@AdiAr11 LGTM. Thank you for your contributions. Thanks

Thank you so much !

@justdvnsh justdvnsh added hacktoberfest-accepted Attached when pr is ready to merge and can be counted for hacktoberfest. ready-to-merge attached when a pr is ready to be merged UI-change Label to put if there is any UI change labels Oct 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justdvnsh justdvnsh justdvnsh approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Attached when pr is ready to merge and can be counted for hacktoberfest. ready-to-merge attached when a pr is ready to be merged UI-change Label to put if there is any UI change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AdiAr11 @justdvnsh