Implementation of the function parseAnimeDetails in class Parser. #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @justdvnsh this screenshot is satisfy ?
|
|
Can i get another issues of tests ? If nobody get of course. |
|
@Bhyan Sure. Just comment on any issue you like and tag me. I'll assign it to you. You can comment on multiple issues if you like. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @justdvnsh, I've finished issue #32. I used the structure Java that I know best and any articles of test on Kotlin, if you think another structure better, let me know and I'll update. i don't know how to assess the coverage of tests in Kotlin, but i think i covered all possibles test from parseAnimeDetails function.